Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adikteev becomes Emoteev #2

Merged

Conversation

piotr-yuxuan
Copy link

No description provided.

@piotr-yuxuan piotr-yuxuan self-assigned this Mar 18, 2019
@jeremyvdw jeremyvdw merged commit 9a51611 into update-adikteev-adapter Mar 18, 2019
piotr-yuxuan added a commit that referenced this pull request Apr 25, 2019
* Improve emoteevBidAdapter

** Squash several pending changes

- Improve test coverage
- Extreme programming: 100% test coverage
- Document important constants
- Extreme programming: document all functions
- Imperative shell, functional core
- Send events onBidWon and onTimeout
- Report GDPR relevance and consent

Code documentation uses JSDoc tags wherever possible. See the
following link for general explanation of the notation used:
https://github.com/google/closure-compiler/wiki/Annotating-JavaScript-for-the-Closure-Compiler

** Test coverage

- 100% Statements 110/110
- 100% Branches 55/55
- 100% Functions 28/28
- 100% Lines 99/99

** Integration tests

Tested against production endpoint with the possible combinations of
these following parameters:

- Browser:
  · Chrome Canary 75.0.3739.0
  · Firefox Developer Edition 67.0b3 (64-bit)
  · Safari version 12.0.3 (14606.4.5)
  · Tor Browser 8.0.6 (based on Mozilla Firefox 60.5.1esr)
- Integration page:
  · integrationExamples/gpt/hello_world_emoteev.html
  · https://jsfiddle.net/8aqotw1k/6/

Localhost test server launched with:
$ npm install && gulp serve

* Tentative CI fix for IE and Edge webGL test

https://circleci.com/gh/prebid/Prebid.js/2052

* Tentative CI fix for IE and Edge webGL test #2

* Give up on webGL tests

Has anybody an idea to make it pass?

https://circleci.com/gh/prebid/Prebid.js/2056

New test coverage:

- 94.5% Statements 103/109
- 98.18% Branches 54/55
- 100% Functions 28/28
- 93.88% Lines 92/98

* Avoid useless noice in diff

* Remove unallowed metric pixel ON_ADAPTER_CALLED
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants